On Sat, Jun 10, 2017 at 02:40:06PM +0300, Roman Storozhenko wrote:
> On Fri, Jun 09, 2017 at 04:30:02PM +0300, Roman Storozhenko wrote:
> > Use 'const' in declarations of various 'file_operations' structures.
> >
> > Signed-off-by: Roman Storozhenko <romeusmeister@xxxxxxxxx>
> > ---
> > drivers/staging/lustre/lustre/llite/file.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/staging/lustre/lustre/llite/file.c b/drivers/staging/lustre/lustre/llite/file.c
> > index 67c4b9c..4072240 100644
> > --- a/drivers/staging/lustre/lustre/llite/file.c
> > +++ b/drivers/staging/lustre/lustre/llite/file.c
> > @@ -3114,7 +3114,7 @@ int ll_inode_permission(struct inode *inode, int mask)
> > }
> >
> > /* -o localflock - only provides locally consistent flock locks */
> > -struct file_operations ll_file_operations = {
> > +struct const file_operations ll_file_operations = {
> > .read_iter = ll_file_read_iter,
> > .write_iter = ll_file_write_iter,
> > .unlocked_ioctl = ll_file_ioctl,
> > @@ -3127,7 +3127,7 @@ struct file_operations ll_file_operations = {
> > .flush = ll_flush
> > };
> >
> > -struct file_operations ll_file_operations_flock = {
> > +struct const file_operations ll_file_operations_flock = {
> > .read_iter = ll_file_read_iter,
> > .write_iter = ll_file_write_iter,
> > .unlocked_ioctl = ll_file_ioctl,
> > @@ -3143,7 +3143,7 @@ struct file_operations ll_file_operations_flock = {
> > };
> >
> > /* These are for -o noflock - to return ENOSYS on flock calls */
> > -struct file_operations ll_file_operations_noflock = {
> > +struct const file_operations ll_file_operations_noflock = {
> > .read_iter = ll_file_read_iter,
> > .write_iter = ll_file_write_iter,
> > .unlocked_ioctl = ll_file_ioctl,
> > --
> > 2.7.4
> >
>
> I have figured out that file operations shouldn't be described as
> 'const' here. So this is a wrong patch.
Why not, they should be able to be marked this way, if you do it
correctly :)
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
