On Fri, 9 Jun 2017 21:23:52 +0300 Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > On Fri, Jun 9, 2017 at 9:04 PM, Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > > On Fri, 9 Jun 2017 15:27:36 +0200 > > Vitaly Kuznetsov <vkuznets@xxxxxxxxxx> wrote: > > > >> +#if IS_ENABLED(CONFIG_HYPERV) > > > > Hmm, this is new to me. I know you can use IS_ENABLED() inside C code, > > but I've never seen it used for preprocessor directives. This usually > > is just: > > > > #ifdef CONFIG_HYPERV > > > > Other than that, this looks fine to me. > > That is the magic of IS_ENABLED(), IS_BUILTIN() macros. > So, the code above is fine as is. > I'm sure it works, but it just adds one more way of doing the same thing. I thought that was what perl was always criticized for, and why people usually prefer python. Don't get me wrong, I prefer oysters over snakes. But I just wanted to point out the lack of consistency here. -- Steve _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
