On Mon, Jan 10, 2011 at 10:03:12AM +1100, ahern.michael.t@xxxxxxxxx wrote: > From: mah <ahern.michael.t@xxxxxxxxx> Please put your "real" name here, the same one you put down below in the Signed-off-by: line. > This patch to usbduxfast.c file that fixes warnings found by checkpatch.pl tool Which warnings? > -static void usbduxfast_firmware_request_complete_handler(const struct firmware > +static void usbduxfast_firmware_req_complete_handler(const struct firmware > *fw, void *context) > { > struct usbduxfastsub_s *usbduxfastsub_tmp = context; > @@ -1577,7 +1585,7 @@ static int usbduxfastsub_probe(struct usb_interface *uinterf, > &udev->dev, > GFP_KERNEL, > usbduxfastsub + index, > - usbduxfast_firmware_request_complete_handler); > + usbduxfast_firmware_req_complete_handler); Renaming the function name just to make the line-length work isn't ok. Just don't make this change. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel