On Sun, Jan 02, 2011 at 11:14:27PM +0100, Javier Martinez Canillas wrote:
> staging: keucr: Use memcpy() instead custom StringCopy() and some style cleanups
>
> Signed-off-by: Javier Martinez Canillas <martinez.javier@xxxxxxxxx>
> ---
> drivers/staging/keucr/smilecc.c | 16 ++++++++++------
> 1 files changed, 10 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/keucr/smilecc.c b/drivers/staging/keucr/smilecc.c
> index daf322a..5659dea 100644
> --- a/drivers/staging/keucr/smilecc.c
> +++ b/drivers/staging/keucr/smilecc.c
> @@ -182,13 +182,17 @@ BYTE *buf;
> BYTE *redundant_ecc;
> BYTE *calculate_ecc;
> {
> - DWORD err;
> + DWORD err;
>
> - err=correct_data(buf,redundant_ecc,*(calculate_ecc+1),*(calculate_ecc),*(calculate_ecc+2));
> - if (err==1) StringCopy(calculate_ecc,redundant_ecc,3);
> - if (err==0 || err==1 || err==2)
> - return(0);
> - return(-1);
> + err = correct_data(buf, redundant_ecc, *(calculate_ecc + 1),
> + *(calculate_ecc), *(calculate_ecc + 2));
> + if (err == 1)
> + memcpy(calculate_ecc, redundant_ecc, 3);
> +
> + if (err == 0 || err == 1 || err == 2)
> + return 0;
> +
> + return -1;
> }
>
> void _Calculate_D_SwECC(buf,ecc)
> --
Now it looks good.
Reviewed-by: Marcin Slusarz <marcin.slusarz@xxxxxxxxx>
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
