Re: [PATCHv4 0/4] staging: keucr: Use memcmp() & memcpy() instead of custom String[Cmp|Copy] functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jan 02, 2011 at 11:14:25PM +0100, Javier Martinez Canillas wrote:
> This patchset make some cleanup to staging/keucr. Use memcmp and memcpy instead of custom functions.
> Also some style cleanups recomended by Dan Carpenter, Joe Perches and Gábor Stefanik.
> 
> The patches in this patchset are the following:
> 
> [PATCH 1/4] staging: keucr: Use memcmp() instead custom StringCmp() and some style cleanups
> [PATCH 2/4] staging: keucr: Use memcpy() instead custom StringCopy() and some style cleanups
> [PATCH 3/4] staging: keucr: Delete StringCmp() and StringCopy custom functions
> [PATCH 4/4] staging: keucr: Delete use kernel strcmp() & strcpy() from TODO file
> 

Looks good.  v1 made me grumpy.  v2 was ok.  v4 is what all patches
should look like.  :)

Acked-by: Dan Carpenter <error27@xxxxxxxxx>

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux