Re: [PATCH 2/3] staging: keucr: Use memcpy() instead custom StringCopy() and some style cleanups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>> + Â Â if (err == 1)
>> + Â Â Â Â Â Â memcpy(calculate_ecc, redundant_ecc, 3);
>> +
>> + Â Â if (err == 0 || err == 2)
>> + Â Â Â Â Â Â return 0;
>> +
>> + Â Â return -1;
>> Â}
>
> That's wrong. Before your change when correct_data returned 1 this function
> returned 0. Now it returns -1.
>
> Marcin
>
>

Yes, I'm preparing a new patchset that also corrects that. Thanks

-- 
Best regards,

-----------------------------------------
Javier MartÃnez Canillas
(+34) 682 39 81 69
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux