Re: [PATCH 1/3] staging: keucr: Use memcmp() instead custom StringCmp() and some style cleanups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2011-01-02 at 22:21 +0100, Javier Martinez Canillas wrote:
> > This code isn't the same.
> > You deleted that return and now you do the driver ECC check.
> > Is that correct?
> You are right Joe, sorry for that. Should I remove the dead code after
> the return SUCCESS or keep it?

As I said before, I think you should delete it.

On Fri, 2010-12-31 at 12:26 -0800, Joe Perches wrote:
> You might as well take out useless code after returns
> instead of just changing function names.
> If you keep it you should reformat it.

Doesn't matter much though.

cheers, Joe

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux