Re: [PATCH] staging: speakup: more fixes for init-failure handling.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I'm not a big fan of the global variables approach to unwinding...  It
makes reading the code much harder.  But I didn't find any run-time bugs
so I guess this is ok.  It fixes the NULL deref I mentioned before.

> +/* These first few initializations cannot fail. */

The indenting is wrong here.

> +	pr_warn("synth name on entry is: %s\n", synth_name);

This should be a pr_info() instead of a pr_warn().

regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux