Re: [PATCH] staging: ath6kl: Fixing device NULL pointer dereference

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 14, 2010 at 5:17 PM, Vipin Mehta <vmehta@xxxxxxxxxxx> wrote:
> Fixing the device instance being passed to set_wiphy_dev() from
> NULL to the one being returned by the MMC stack probe callback.
>
> Signed-off-by: Vipin Mehta <vmehta@xxxxxxxxxxx>
> ---
> Âdrivers/staging/ath6kl/os/linux/ar6000_drv.c | Â 19 ++++++++++++-------
> Â1 files changed, 12 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/ath6kl/os/linux/ar6000_drv.c b/drivers/staging/ath6kl/os/linux/ar6000_drv.c
> index a659f70..9f3e928 100644
> --- a/drivers/staging/ath6kl/os/linux/ar6000_drv.c
> +++ b/drivers/staging/ath6kl/os/linux/ar6000_drv.c
> @@ -1608,6 +1608,15 @@ ar6000_avail_ev(void *context, void *hif_handle)
> Â Â struct wireless_dev *wdev;
> Â#endif /* ATH6K_CONFIG_CFG80211 */
> Â Â A_STATUS init_status = A_OK;
> + Â ÂHIF_DEVICE_OS_DEVICE_INFO osDevInfo;
> +
> + Â ÂA_MEMZERO(&osDevInfo, sizeof(osDevInfo));
> + Â Âif ( A_FAILED( HIFConfigureDevice(hif_handle, HIF_DEVICE_GET_OS_DEVICE,
> + Â Â Â Â Â Â Â Â Â Â&osDevInfo, sizeof(osDevInfo))) )

while you are adding new code, why not use the direct Linux calls?

  Luis
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux