> -----Original Message----- > From: Jesper Juhl [mailto:jj@xxxxxxxxxxxxx] > Sent: Monday, December 13, 2010 3:51 PM > To: Ky Srinivasan > > > + shut_txf_buf = kmalloc(PAGE_SIZE, GFP_ATOMIC); > > > + time_txf_buf = kmalloc(PAGE_SIZE, GFP_ATOMIC); > > > + hbeat_txf_buf = kmalloc(PAGE_SIZE, GFP_ATOMIC); > > Why are these allocations GFP_ATOMIC. Clearly this is in module > loading context and you can afford to sleep. GFP_KERNEL should be fine. > > > > I actually also noticed this when I did my first review of the patch, > but > I didn't point it out since I thought that "there must be a good > reason". > But now that you point it out and I look at the code once more I can't > actually think of a "good reason",, so I agree with you completely that > these should just be GFP_KERNEL. I was looking at some of the back code to make sure it is okay, and I see No reason not make this change either. I will change it and resubmit. Thanks, Hank. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
