> -----Original Message----- > From: Jesper Juhl [mailto:jj@xxxxxxxxxxxxx] > Sent: Monday, December 13, 2010 12:48 PM > You are leaking memory in the failure path. If for example one or two > allocations succeed but one or two fail, then you'll leak the two successful > allocations. > > I believe this should be > > if (!shut_txf_buf || !time_txf_buf || !hbeat_txf_buf) { > printk(KERN_INFO > "Unable to allocate memory for receive buffer\n"); > kfree(hbeat_txf_buf); > kfree(time_txf_buf); > kfree(shut_txf_buf); > return -ENOMEM; > ... > Oops, you are correct. Resubmitting the patch in a few minutes. Hank. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
