On Sun, Dec 12, 2010 at 11:04:28AM -0800, Joe Perches wrote:
> On Sun, 2010-12-12 at 18:56 +0100, L. Alberto Giménez wrote:
> > Fix checkpatch complains
> > diff --git a/drivers/staging/rt2860/common/ee_efuse.c b/drivers/staging/rt2860/common/ee_efuse.c
> []
> > @@ -281,8 +281,8 @@ int set_eFusedump_Proc(struct rt_rtmp_adapter *pAd, char *arg)
> >
> > eFuseReadPhysical(pAd, &InBuf[0], 4, &InBuf[2], 2);
> > if (i % 4 == 0)
> > - printk("\nBlock %x:", i / 8);
> > - printk("%04x ", InBuf[2]);
> > + printk(KERN_DEBUG "\nBlock %x:", i / 8);
> > + printk(KERN_DEBUG "%04x ", InBuf[2]);
> > }
> > return TRUE;
> > }
>
> Not quite. Use:
>
> (before the for)
> printk(KERN_DEBUG "Block 0: ");
>
> for(...)
> []
> if (i && i % 4 == 0) {
> printk(KERN_CONT "\n");
> printk(KERN_DEBUG "Block %x: ", i / 8);
> }
> printk(KERN_CONT " %04x", InBuf[2]);
> }
> printk(KERN_CONT "\n");
>
This is dead code anyway. Just remove the whole set_eFusedump_Proc()
function.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
