On Fri, Dec 10, 2010 at 12:35:33PM -0500, Dave Jones wrote:
> On Thu, Dec 09, 2010 at 01:43:36PM +0300, Dan Carpenter wrote:
> > > + file = debugfs_create_file("device", S_IRUGO | S_IWUGO, dir,
> > ^^^^^^^
> > > + NULL, &ft1000fops);
> >
> > Don't make this world writeable.
>
> we should probably make checkpatch catch this.
>
>
>
>
> Exporting world writable sysfs/debugfs files is usually a bad thing.
> Warn about it.
>
> Signed-off-by: Dave Jones <davej@xxxxxxxxxx>
Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
