RE: [PATCH 05/12] staging: brcm80211: replaced typedef wlc_ap_info_t by struct wlc_ap_info

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Dan,

Acknowledged. Indeed it is a better idea to delete this struct. I will do this in a subsequent patch and delete the wlc_mac80211.c comments as well. Greg, is that ok with you (so proceed with the current patch and you will get an additional patch from me) ? 

Thanks, Roland.

-----Original Message-----
From: Dan Carpenter [mailto:error27@xxxxxxxxx] 
Sent: Tuesday, December 07, 2010 11:45 AM
To: Roland Vossen
Cc: gregkh@xxxxxxx; devel@xxxxxxxxxxxxxxxxxxxxxx
Subject: Re: [PATCH 05/12] staging: brcm80211: replaced typedef wlc_ap_info_t by struct wlc_ap_info

On Tue, Dec 07, 2010 at 10:39:39PM +0300, Dan Carpenter wrote:
> > -	wlc_ap_info_t *ap;
> > +	struct wlc_ap_info *ap;
> > 
> 
> This isn't used any more.  It would be better to delete both the lines
> instead of updating them.
> 

Btw.  The bits that used to use it are in
drivers/staging/brcm80211/sys/wlc_mac80211.c, but they're commented out.
You could delete the comments as well.

regards,
dan carpenter




_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux