On Fri, Nov 19, 2010 at 07:33:57PM +0000, Jonathan Cameron wrote: > On 10/29/10 15:46, Matthias Brugger wrote: > > This patch adds support for the Bosch Sensortec bmp085 digital > > barometer to the iio subsystem. > Hi Matthias, > > Pretty clean driver. Various minor comments inline. > > The controversial thing about this driver is that it is (I think) > the first time we are going to have a driver in iio for a device > that already has a driver elsewhere in the kernel tree. (in misc). > This makes me rather uncomfortable... Ick, that's not good. What's the future of the misc driver if this one goes in as well? > One crucial thing is that we need a todo file listing anything that > driver does that this one does not. I would also like to get some > feedback on this from the author of the existing driver. I have > cc'd him. At a very quick glance, the key thing that driver does > that isn't present here is that it ensures there is a recent enough > temperature measurement in driver. Otherwise they are in many ways > pretty similar. Obviously I'm happy to have barometric pressure sensors > in IIO but I don't want to step on anyones toes and things will get > 'interesting' when we move out of staging. The existing driver > almost certainly has a userspace so any changes are going to cause > pain and will need to be done slowly and carefully. Yeah, Matthias, why did you write a new driver for this in the first place? What is missing from the in-kernel driver that you needed? Why not just add that to the existing driver? thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
