As I'm guessing you are going to be sending a lot of patches in the future, let's get this correct so I don't have to manually edit every patch you send :) On Wed, Nov 17, 2010 at 05:39:36PM +0100, Arend van Spriel wrote: > >From f5fceb92da34711caa136735aa2f14249e6cafe9 Mon Sep 17 00:00:00 2001 > From: Arend van Spriel <arend@xxxxxxxxxxxx> > Date: Fri, 12 Nov 2010 10:07:27 +0100 > Subject: [PATCH 1/3] staging: brcm80211: updated maintainers contact information What is that doing in the body? Please don't duplicate it, it is unnecessary and implies that you did not use git-send-email to send the patch, right? > > > Reviewed-by: Brett Rudley <brudley@xxxxxxxxxxxx> > Signed-off-by: Arend van Spriel <arend@xxxxxxxxxxxx> No text in the body of the changelog? I know this seems trivial, but please always try to put something in every patch changelog. Otherwise I'll just guess and put something random there :) > --- > drivers/staging/brcm80211/README | 8 +++++--- > drivers/staging/brcm80211/TODO | 4 +++- > 2 files changed, 8 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/brcm80211/README b/drivers/staging/brcm80211/README > index c3ba9bb..de65f9d 100644 > --- a/drivers/staging/brcm80211/README > +++ b/drivers/staging/brcm80211/README > @@ -80,15 +80,17 @@ appropriate other traffic is observed on those channels. > Within the driver, we use the ficticious country code "X2" to represent this > worldwide regulatory domain. There is currently no interface to configure a > different domain. > > The driver reads the SROM country code from the chip and hands it up to > mac80211 as the regulatory hint, however this information is otherwise unused > with the driver. > > > Contact Info: > ============= > -Brett Rudley brudley@xxxxxxxxxxxx > -Henry Ptasinski henryp@xxxxxxxxxxxx > -Nohee Ko noheek@xxxxxxxxxxxx > +Brett Rudley brudley@xxxxxxxxxxxx > +Henry Ptasinski henryp@xxxxxxxxxxxx > +Dowan Kim dowan@xxxxxxxxxxxx > +Roland Vossen rvossen@xxxxxxxxxxxx > +Arend van Spriel arend@xxxxxxxxxxxx > > diff --git a/drivers/staging/brcm80211/TODO b/drivers/staging/brcm80211/TODO > index 8803d30..24ebadb 100644 > --- a/drivers/staging/brcm80211/TODO > +++ b/drivers/staging/brcm80211/TODO > @@ -37,13 +37,15 @@ Other > - Replace driver's proprietary ssb interface with generic kernel ssb module > (only used when compiling for SDIO). > - PCI and SDIO support are currently #ifdef'ed exclusive of each other, which > leads to a separate wl.ko for each. This should be changed to runtime > handling of different interfaces so that a single binary driver can be built. > - Add support for new chips (obviously an ongoing item). > > Contact > ===== > Brett Rudley <brudley@xxxxxxxxxxxx> > Henry Ptasinski <henryp@xxxxxxxxxxxx> > -Nohee Ko <noheek@xxxxxxxxxxxx> > +Dowan Kim <dowan@xxxxxxxxxxxx> > +Roland Vossen <rvossen@xxxxxxxxxxxx> > +Arend van Spriel <arend@xxxxxxxxxxxx> What kernel version did you make this against? This doesn't apply against my tree as this file has already been changed there. Care to redo all of these and resend them please? thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
