> Heh, that's funny. Someone went through a lot of work for no reason. Not really... that was to workaround problems we were seeing years ago with a buggy 02Micro 0Z6912 Cardbus Controller in HP laptops that would occasionally corrupt pci config accesses. I'm assuming this just isn't a problem any longer that this driver needs to worry about. > Do you really want to read every write that happens here for one > specific offset? Why? No not particularly ;-) It was part of the above. I'll fix this quickly. > > And ASSERTs should be removed anyway, right? Any tips on which is the right macro to use? (I'm assuming you mean we are using the wrong macros not that we shouldn't check) I see some drivers with BUG, BUG_ON, BUILD_BUG, BUILD_BUG_ON_ZERO, etc. Thanks Brett > > I'll queue up the patch. > > thanks, > > greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
