On 12/11/10 15:11, Emilio G. Cota wrote: > On Fri, Nov 12, 2010 at 11:23:13 +0000, Martyn Welch wrote: >> Hi Greg, >> >> Here's the series of patches from Emilio I have been through and Acked. >> >> Sorry for not sending this sooner, bad health kept me from work. I have >> promised to work through the remaining patches for Emilio, however the >> absence from work and work commitments means this is going to take a >> little longer than I had hoped (sorry Emilio). It is on my "todo" list. > > Don't worry, as I said there's no rush in getting this merged (in > production we're still using a fairly old kernel). > > Hope you're well now. > Getting there cheers, I'm off the hardcore pain-killers, not in excruciating pain and fed up with day-time TV, so back at work ;) >> I have applied minor edits to some of the patches to remove checkpatch >> warnings, stacked git has the habit of correcting chunk offsets (which >> may occur when re-ordering patches etc.), but I believe the others are >> as sent by Emilio (with the addition of my ack). > > Just FYI, if those checkpatch warnings were about lines exceeding 80 > characters, I consciously ignored them. After reading this[1] message I > stopped trimming long lines, especially if they're just a few characters > over the magic number. > Yeah they were. I have a little python GUI I knocked up to help make sure I send patch series correctly and don't have to keep working out the options I need (long way from perfect yet), it refuses to allow me to send if check patch doesn't pass and the few warnings were easier to deal with than looking at improving the GUI! Martyn > Anyway this is just code formatting, either way is fine with me. > > Thanks, > > Emilio > > [1] http://lkml.org/lkml/2009/12/17/229 > -- Martyn Welch (Principal Software Engineer) | Registered in England and GE Intelligent Platforms | Wales (3828642) at 100 T +44(0)127322748 | Barbirolli Square, Manchester, E martyn.welch@xxxxxx | M2 3AB VAT:GB 927559189 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel