Re: [patch] Staging: rtl8712: signedness bug in init

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/11/2010 11:11 PM, Dan Carpenter wrote:
> PollingCnt is 20 and that means we loop 20 times and then run the
> timeout code.  After the end of the loop PollingCnt should be -1 but
> because it's an unsigned char, it's actually 255 and the timeout
> code never runs.
> 
> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>

Acked-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx>

As a point of interest, did you actually hit a timeout, or was this found by a
code audit?

Larry
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux