Re: [PATCH] staging: batman-adv: Use linux/etherdevice.h address helper functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2010-11-03 at 11:12:12 +0100, Sven Eckelmann <sven.eckelmann@xxxxxx> wrote:
> On Wednesday 03 November 2010 10:59:02 you wrote:
> > Replace custom ethernet address check functions by calls to the helpers
> > in linux/etherdevice.h
> 
> Have you proven that the addresses are always two bytes aligned in memory? 
> Afaik this function needs it.

I don't think they need to be two bytes aligned, but I might be wrong.

> > In one case where the address was tested for broadcast and multicast
> > address, the broadcast address check can be omitted as broadcast is also
> > a multicast address.
> 
> We need to distinguish between these two types for different optimizations 
> (research is currently done for multicast over mesh - but currently not part 
> of batman-adv).

I was refering to the following part of the patch:

-       if (is_bcast(ethhdr->h_dest) || is_mcast(ethhdr->h_dest)) {
+       if (is_multicast_ether_addr(ethhdr->h_dest)) {

I think this change should be legitimate as the same branch is done for
multicast and broadcast addresses.

Thanks
Tobias
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux