On Tue, 2010-11-02 at 16:31 +0100, Audun Hoem wrote:
> Cleaned up a macro definition and another simple style warning.
> Signed-off-by: Audun Hoem <audun.hoem@xxxxxxxxx>
> ---
> drivers/staging/frontier/alphatrack.c | 9 ++++++---
> 1 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/frontier/alphatrack.c b/drivers/staging/frontier/alphatrack.c
> index ef7fbf8..6e3bd73 100644
> --- a/drivers/staging/frontier/alphatrack.c
> +++ b/drivers/staging/frontier/alphatrack.c
> @@ -88,8 +88,11 @@ MODULE_SUPPORTED_DEVICE("Frontier Designs Alphatrack Control Surface");
> static int debug = ALPHATRACK_DEBUG;
>
> /* Use our own dbg macro */
> -#define dbg_info(dev, format, arg...) do \
> - { if (debug) dev_info(dev , format , ## arg); } while (0)
> +#define dbg_info(dev, format, arg...) \
> +do { \
> + if (debug) \
> + dev_info(dev , format , ## arg); \
There is no need for the spaces before commas.
gcc 2.xx required a space before a comma with a trailing ##arg,
but that compiler version is no longer supported.
This should be:
dev_info(dev, format, ##arg);
though I think using dev_dbg and getting rid of the dbg_info
macro is better.
> +} while (0)
>
> #define alphatrack_ocmd_info(dev, cmd, format, arg...)
>
> @@ -769,7 +772,7 @@ static int usb_alphatrack_probe(struct usb_interface *intf,
> }
>
> dev->write_buffer =
> - kmalloc(sizeof(struct alphatrack_ocmd) * true_size, GFP_KERNEL);
> + kmalloc(sizeof(struct alphatrack_ocmd) *true_size, GFP_KERNEL);
Not an improvement.
If checkpatch warns about this, it's a checkpatch defect.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
