Re: [PATCH 07/30] staging/vme/tsi148: remove double freeing of the IRQ in .remove

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 26/10/10 02:10, Emilio G. Cota wrote:
> From: Emilio G. Cota <cota@xxxxxxxxx>
> 
> tsi148_irq_exit is called twice in .remove, which causes an oops.
> 
> Remove the second call, which apart from being redundant cannot
> possibly work; the CR/CSR space has been already unmapped.
> 
> Signed-off-by: Emilio G. Cota <cota@xxxxxxxxx>

Acked-by: Martyn Welch <martyn.welch@xxxxxx>

> ---
>  drivers/staging/vme/bridges/vme_tsi148.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/vme/bridges/vme_tsi148.c b/drivers/staging/vme/bridges/vme_tsi148.c
> index 660968e..acfbd59 100644
> --- a/drivers/staging/vme/bridges/vme_tsi148.c
> +++ b/drivers/staging/vme/bridges/vme_tsi148.c
> @@ -2612,8 +2612,6 @@ static void tsi148_remove(struct pci_dev *pdev)
>  		kfree(master_image);
>  	}
>  
> -	tsi148_irq_exit(bridge, pdev);
> -
>  	iounmap(bridge->base);
>  
>  	pci_release_regions(pdev);


-- 
Martyn Welch (Principal Software Engineer)   |   Registered in England and
GE Intelligent Platforms                     |   Wales (3828642) at 100
T +44(0)127322748                            |   Barbirolli Square,
Manchester,
E martyn.welch@xxxxxx                        |   M2 3AB  VAT:GB 927559189
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux