It's odd. I've checked it before submission: andy@fs-test:~/prj/linux-2.6(mine)$ git show 77099f0afe94928b5b0066a7efa5fa9f81696b54 | scripts/checkpatch.pl - total: 0 errors, 0 warnings, 177 lines checked Your patch has no obvious style problems and is ready for submission. On Tue, Oct 26, 2010 at 12:43 AM, Sven Eckelmann <sven.eckelmann@xxxxxx> wrote: > 77099f0afe94928b5b0066a7efa5fa9f81696b54 added changes to vis.c which > trigger a checkpatch.pl warning about braces which are not necessary > anymore. > > WARNING: braces {} are not necessary for any arm of this statement > + Â Â Â Â Â Â Â if (entry->primary) > [...] > + Â Â Â Â Â Â Â else { > [...] > > Signed-off-by: Sven Eckelmann <sven.eckelmann@xxxxxx> > Cc: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > Cc: Marek Lindner <lindner_marek@xxxxxxxx> > Cc: Simon Wunderlich <siwu@xxxxxxxxxxxxxxxxxx> > Cc: Andrew Lunn <andrew@xxxxxxx> > --- > Âdrivers/staging/batman-adv/vis.c | Â Â3 +-- > Â1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/batman-adv/vis.c b/drivers/staging/batman-adv/vis.c > index 3d2c1bc..4473cc8 100644 > --- a/drivers/staging/batman-adv/vis.c > +++ b/drivers/staging/batman-adv/vis.c > @@ -135,9 +135,8 @@ static ssize_t vis_data_read_prim_sec(char *buff, struct hlist_head *if_list) > Â Â Â Âhlist_for_each_entry(entry, pos, if_list, list) { > Â Â Â Â Â Â Â Âif (entry->primary) > Â Â Â Â Â Â Â Â Â Â Â Âlen += sprintf(buff + len, "PRIMARY, "); > - Â Â Â Â Â Â Â else { > + Â Â Â Â Â Â Â else > Â Â Â Â Â Â Â Â Â Â Â Âlen += sprintf(buff + len, Â"SEC %pM, ", entry->addr); > - Â Â Â Â Â Â Â } > Â Â Â Â} > > Â Â Â Âreturn len; > -- > 1.7.2.3 > > -- With Best Regards, Andy Shevchenko _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel