Re: [PATCH] staging:brcm80211:brcmfmac:add dongle power on/off functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 21, 2010 at 10:46:33AM -0700, Nohee Ko wrote:
> Hi Greg,
> 
> >>>
> And most importantly, the developers involved AGREED with my "no more
> features" rule, and then instantly turned around and ignored it.  How
> would you treat such a thing if you were a maintainer?
> <<<
> 
> I am sorry if you feel like ignored by us.
> I understand your point that code clean should go first to get out of
> staging tree. Actually we are giving effort code-clean work in
> parallel as well.

Ok, but I haven't seen much from that.  Actually, I think I've done more
code cleanup to this driver than anyone else at the moment...

> And from now on we will definitely spend more time for code cleaning.
> However we also need to add necessary features in time to make progress in current project.

What "project"?  What's the rush?

Again, I really want to see more cleanup happening here before any new
features are added.

This goes for other staging drivers as well, you aren't the only one
that this has happened to in the past, so don't feel like I am singling
you out for anything here.

> Again we will put more time to code cleaning from now on and in the
> meantime, we may need to add small new features and some bug fixes.

Bug fixes are fine.  New features are not.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux