On Sun, Oct 17, 2010 at 03:10:33PM -0700, Grant Grundler wrote: > ... > > In short, I think you mixed a few different things in this patch. > > > > Please break it up into logical steps, one perhaps adding some new > > infrastructure that you will then, in a later patch, expose using > > debugfs. > > > > It should be two patches at the very least, possibly three, right? > > Here's what I see...please suggest something different if you think > I've missed something: > 1) clean up use of active_scan in wl_do_iscan()/__wl_cfg80211_scan > 2) add DEBUGFS support equivalent to what mac80211 provides. Um, no, how about: 2) move the driver to use the mac80211 layer Don't try to emulate the existing core debugfs functionality, it will be a constantly loosing proposition of keeping it in sync. As the driver needs to be moved to us the layer in order to get out of the staging tree, might as well work on that first, right? thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
