Re: [patch 1/2] Staging: ft1000-usb: use the correct list head

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 15, 2010 at 5:40 AM, Dan Carpenter <error27@xxxxxxxxx> wrote:
> Using pdpram_blk here would cause an oops. ÂWe intended to use
> &freercvpool.
>
> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>
>
> diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c b/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c
> index d0637c3..076ba75 100644
> --- a/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c
> +++ b/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c
> @@ -1115,7 +1115,7 @@ u16 init_ft1000_netdev(struct ft1000_device *ft1000dev)
>
>
> Âerr_free:
> - Â Â Â list_for_each_safe(cur, tmp, &pdpram_blk->list) {
> + Â Â Â list_for_each_safe(cur, tmp, &freercvpool) {
> Â Â Â Â Â Â Â Âpdpram_blk = list_entry(cur, DPRAM_BLK, list);
> Â Â Â Â Â Â Â Âlist_del(&pdpram_blk->list);
> Â Â Â Â Â Â Â Âkfree(pdpram_blk->pbuffer);
>

Greg, you can add my Tested by: Marek Belisko <marek.belisko@xxxxxxxxx>

@Dan, good catch. Thanks.

Marek


-- 
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
icq: 290551086
web: http://open-nandra.com
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux