Re: [PATCH 3/3] staging: brcm80211: fix to use "%pM" flag to print MAC address

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2010-10-10 at 13:20 +0300, Andy Shevchenko wrote:

>  char *bcm_ether_ntoa(const struct ether_addr *ea, char *buf)
>  {
> -	static const char template[] = "%02x:%02x:%02x:%02x:%02x:%02x";
> -	snprintf(buf, 18, template,
> -		 ea->octet[0] & 0xff, ea->octet[1] & 0xff, ea->octet[2] & 0xff,
> -		 ea->octet[3] & 0xff, ea->octet[4] & 0xff, ea->octet[5] & 0xff);
> +	snprintf(buf, 18, "%pM", ea->octet);

That's a pretty strange use of snprintf -- just use sprintf if you don't
have a real buffer length.

johannes

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux