On Thu, Sep 30, 2010 at 11:23:03PM +0400, Vasiliy Kulikov wrote: > On Thu, Sep 30, 2010 at 04:13 -0700, Greg KH wrote: > > On Tue, Sep 28, 2010 at 09:49:35PM +0400, Vasiliy Kulikov wrote: > > > ft1000_copy_up_pkt() doesn't free skb on errors. > > > init_ft1000_card() doesn't free netdev with free_netdev() but with kfree(). > > > init_ft1000_card() doesn't check request_region()'s return value > > > and doesn't free region on error. > > > > > > Signed-off-by: Vasiliy Kulikov <segooon@xxxxxxxxx> > > > --- > > > Compile tested. > > > > No you didn't > > No I did: > > make -C /home/vasya/linux drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.o > make: ÐÑÐÐ Ð ÐÐÑÐÐÐÐ `/home/vasya/dev/linux-next' > CHK include/linux/version.h > CHK include/generated/utsrelease.h > CALL scripts/checksyscalls.sh > CC drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.o > drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c: In function âft1000_reset_cardâ: > drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c:525: warning: passing argument 2 of âcard_downloadâ discards qualifiers from pointer target type > drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c:56: note: expected âvoid *â but argument is of type âconst u8 * constâ > make: ÐÑÑÐÐ ÐÐ ÐÐÑÐÐÐÐÐ `/home/vasya/dev/linux-next' Heh, I didn't think to try that, amazed that it worked at all. > However, > > cd ../drivers/staging/ft1000/ft1000-pcmcia/ > LANG=C make -C ~/linux ft1000_hw.o > make: Entering directory `/home/vasya/dev/linux-next' > make: *** No rule to make target `ft1000_hw.o'. Stop. > make: Leaving directory `/home/vasya/dev/linux-next' > > > Is "make" from linux root buggy/not supported for staging/everything? This driver is marked broken, look at the Kconfig file: config FT1000_PCMCIA tristate "Driver for ft1000 pcmcia device." depends on PCMCIA && BROKEN It will be fixed up soon hopefully. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
