I tested v3, and it scans, associates to an open network, and pings fine. There appears to be a problem with WPA2 networks, but that problem exists without Jason's patches. There appears to be a v4 in the works ... - Henry Henry Ptasinski henryp@xxxxxxxxxxxx ----- Original Message ----- From: Greg KH <greg@xxxxxxxxx> To: Jason Cooper <jason@xxxxxxxxxxxxxx> Cc: Henry Ptasinski; devel@xxxxxxxxxxxxxxxxxxxxxx <devel@xxxxxxxxxxxxxxxxxxxxxx> Sent: Thu Sep 30 04:48:34 2010 Subject: Re: [PATCH v2] staging/brcm80211: remove assignments in if conditions On Wed, Sep 29, 2010 at 10:19:27PM -0400, Jason Cooper wrote: > Greg, Henry, > > This is version 2 of bringing brcm80211/brcmfmac/ up to par as far as removal > of checkpatch errors. > > At the recommendation of Joe Perches, I reverted the change in > brcmfmac/dhd_linux.c:1867 . All else is the same. I want to get Henry's ACK on these before applying them, as he can test them, and I can't :) Henry? thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel