On Wed, Sep 29, 2010 at 12:25:22PM -0400, pavan_savoy@xxxxxx wrote: > From: Pavan Savoy <pavan_savoy@xxxxxx> > > Greg, > > How is the movement of drivers done out of staging? > Should I submit patches like these, which move individual files without > breaking the build during anytime of movement? Yes. > In few following days I plan to submit patches to move the ST headers sources > out. > ti_wilink_st.h -> include/linux/ > st_core.c, st_kim.c and st_ll.c -> drivers/misc/ > Makefile and Kconfig changes to drivers/misc/Kconfig and drivers/misc/Makefile > bt_drv.c -> drivers/bluetooth/ Yes, that sounds great. But, the bluetooth patch should go to the bluetooth maintainer for his review, I'll need the ack from him before I can apply it. Oh, this patch looks nice, but I found one problem: > --- a/drivers/staging/ti-st/ti_wilink_st.h > +++ /dev/null > -#ifndef TI_WILINK_ST_H > -#define TI_WILINK_ST_H > - > -/* TODO: > - * Move the following to tty.h upon acceptance > - */ > -#define N_TI_WL 22 /* Ldisc for TI's WL BT, FM, GPS combo chips */ We need to do that now, before you move this file. Then, you can drop this: > -#ifdef __KERNEL__ As it will not be needed, right? Care to send me a patch that does this first? thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel