On Wed, Sep 29, 2010 at 10:01:28PM -0700, Brett Rudley wrote: > > Cleanup unsightly extraneous #include's. (No actual code changes) > > Signed-off-by: Brett Rudley <brudley@xxxxxxxxxxxx> > --- > drivers/staging/brcm80211/sys/wl_mac80211.c | 23 ----------------------- > drivers/staging/brcm80211/sys/wlc_alloc.c | 8 -------- > drivers/staging/brcm80211/sys/wlc_ampdu.c | 3 --- > drivers/staging/brcm80211/sys/wlc_antsel.c | 6 ------ > drivers/staging/brcm80211/sys/wlc_mac80211.c | 4 ---- > drivers/staging/brcm80211/sys/wlc_stf.c | 3 --- > 6 files changed, 0 insertions(+), 47 deletions(-) > > diff --git a/drivers/staging/brcm80211/sys/wl_mac80211.c b/drivers/staging/brcm80211/sys/wl_mac80211.c > index 941b4a3..629aae6 100644 > --- a/drivers/staging/brcm80211/sys/wl_mac80211.c > +++ b/drivers/staging/brcm80211/sys/wl_mac80211.c > @@ -16,45 +16,22 @@ > > #define __UNDEF_NO_VERSION__ > > -#include <typedefs.h> > #include <linuxver.h> > #include <osl.h> > -#include <linux/module.h> > -#include <linux/types.h> > -#include <linux/errno.h> > -#include <linux/pci.h> > -#include <linux/init.h> > -#include <linux/kernel.h> > -#include <linux/netdevice.h> > #include <linux/etherdevice.h> > -#include <linux/skbuff.h> > -#include <linux/delay.h> > -#include <linux/string.h> > -#include <linux/ethtool.h> > -#include <linux/completion.h> > #include <linux/pci_ids.h> Ick, so "osl.h" includes these? Having header files include header files is generally frowned on, as you really don't know what the actual .c file needs. So please go the other way here, remove the #includes from osl.h, linuxver.h and your other local .h files, and then you can remove includes from the .c files for those you don't really need. Sound good? thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
