Re: [PATCH] staging: crystalhd: fix signed bug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Sep 12, 2010 at 10:56:51PM +0400, Vasiliy Kulikov wrote:
> chd_dec_major is unsigned, so check chd_dec_major < 0 doesn't make sense.
> Since it is used as signed, declare it as int.
> 
> Signed-off-by: Vasiliy Kulikov <segooon@xxxxxxxxx>

Indeed, Bad Things here when we try to store the ret from register_chrdev
in an unsigned int and test it for < 0...

Acked-by: Jarod Wilson <jarod@xxxxxxxxxx>

-- 
Jarod Wilson
jarod@xxxxxxxxxx

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux