staging/brcm80211: remove assignments in if conditions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Greg,

I'm now working on bringing brcm80211/brcmfmac/ up to par as far as removal
of checkpatch errors.

Please note, for the following case, I chose the literal interpretation.
I could use a sanity check.

if ((a = some_func(args)) || (b = other_func(more_args))) {
	do_some_stuff;
}

Became:

a = some_func(args);
if (a) {
	do_some_stuff;
} else {
	b = other_func(more_args);
	if (b)
		do_some_stuff;
}

ie, other_func() will _only_ be executed if 'a' is zero.  I'm not sure if
this is what the original authors intended, but it is how I believe it will,
and has been, behaving.  ;-)

thx,

Jason.

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux