On Mon, 27 Sep 2010 11:45:01 +0200 Belisko Marek wrote:
> Signed-off-by: Marek Belisko <marek.belisko@xxxxxxxxx>
> ---
> drivers/staging/ft1000/ft1000-pcmcia/boot.h | 195 ++----
> drivers/staging/ft1000/ft1000-pcmcia/ft1000.h | 346 +++++-----
> drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c | 61 +-
> drivers/staging/ft1000/ft1000-pcmcia/ft1000_dev.h | 16 +-
> drivers/staging/ft1000/ft1000-pcmcia/ft1000_dnld.c | 269 ++++-----
> drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 675 ++++++++++----------
> drivers/staging/ft1000/ft1000-pcmcia/ft1000_proc.c | 34 +-
> 7 files changed, 756 insertions(+), 840 deletions(-)
>
> diff --git a/drivers/staging/ft1000/ft1000-pcmcia/boot.h
> b/drivers/staging/ft1000/ft1000-pcmcia/boot.h
odd line break there.
> index 1fc4ac1..9deacbd 100644
> --- a/drivers/staging/ft1000/ft1000-pcmcia/boot.h
> +++ b/drivers/staging/ft1000/ft1000-pcmcia/boot.h
> @@ -27,132 +27,75 @@
> diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000.h
> b/drivers/staging/ft1000/ft1000-pcmcia/ft1000.h
and there.
> index 61e1cfc..718d197 100644
> --- a/drivers/staging/ft1000/ft1000-pcmcia/ft1000.h
> +++ b/drivers/staging/ft1000/ft1000-pcmcia/ft1000.h
Oh, I see. gmail isn't good about long text lines -- it splits
them into pieces. You'll need to do something about how you send
patches.
> diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c
> b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c
> index 2163eae..07a68fc 100644
> --- a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c
> +++ b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c
> @@ -39,7 +39,7 @@
> #include <linux/netdevice.h>
> #include <linux/etherdevice.h>
>
> -//#include <pcmcia/version.h> // Slavius 21.10.2009 removed from kernel
> +//#include <pcmcia/version.h> // Slavius 21.10.2009 removed
> from kernel
Such a whitespace change does not matter. Same is true for many other places.
It seems to me that we need something in Documentation/CodingStyle that says
that scripts/Lindent should not be used blindly -- its output must be checked.
> #include <pcmcia/cs_types.h>
> #include <pcmcia/cs.h>
> #include <pcmcia/cistpl.h>
> @@ -51,7 +51,7 @@
> #include <asm/byteorder.h>
> #include <asm/uaccess.h>
>
> -#include "ft1000_cs.h" // Slavius 21.10.2009 because CS_SUCCESS
> constant is missing due to removed pcmcia/version.h
> +#include "ft1000_cs.h" // Slavius 21.10.2009 because CS_SUCCESS
> constant is missing due to removed pcmcia/version.h
>
> /*====================================================================*/
>
> @@ -97,7 +98,7 @@ static void ft1000_release(struct pcmcia_device *link);
> */
>
> static void ft1000_detach(struct pcmcia_device *link);
> -static int ft1000_attach(struct pcmcia_device *link);
> +static int ft1000_attach(struct pcmcia_device *link);
That one is good.
>
> typedef struct local_info_t {
> struct pcmcia_device *link;
> @@ -109,7 +110,7 @@ typedef struct local_info_t {
>
> /*====================================================================*/
>
> -static void ft1000_reset(struct pcmcia_device * link)
> +static void ft1000_reset(struct pcmcia_device *link)
so is that one.
But I don't know of anyone who has time to review a 112 KB patch or
a 384 KB patch (patch 1/2).
> {
> conf_reg_t reg;
>
Sorry, I can't review the rest of it. No more time.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
