Minor proceedure issues: Your Subject: should say what you are patching. Something like: Subject: staging: brcm80211: fix compile issue when BRCM80211_PCI is not set would be the correct one for this patch. On Sun, Sep 26, 2010 at 01:18:38PM -0700, Henry Ptasinski wrote: > >From 9b388c53095e7e3aea1e2707f74e03727e5723f3 Mon Sep 17 00:00:00 2001 > From: Henry Ptasinski <henryp@xxxxxxxxxxxx> > Date: Sun, 26 Sep 2010 13:02:17 -0700 > Subject: [PATCH 1/2] Fix compile issue when BRCM80211_PCI is not set. Don't dump the email header again in the email body. I have to edit this out so there's no duplication. > > > Signed-off-by: Henry Ptasinski <henryp@xxxxxxxxxxxx> No body of what the patch does here? Yes, it's a pretty obvious thing here, but still a one sentance description a bit more verbous than the Subject would be good to have. I'll clean these two patches up, but in the future, please work on this. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
