Re: [PATCH] staging: ft1000: fix error path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Sep 26, 2010 at 15:11 +0200, Dan Carpenter wrote:
> On Sun, Sep 26, 2010 at 12:59:55PM +0400, Vasiliy Kulikov wrote:
> > +err_free:
> > +	for (i--; i>=0; i--) {
> > +		kfree(pdpram_blk->pbuffer);
> > +		kfree(pdpram_blk);
> > +	}
> 
> This is wrong.

Of course, I'm very careless.  Pointers are linked into the list and the right code
should loop the list and free both pointers.  I'll post patch v2 tomorrow.

-- 
Vasiliy
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux