RE: [PATCH 1/1] Staging: ti-st: remove st_get_plat_device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Greg,


> -----Original Message-----
> From: Greg KH [mailto:gregkh@xxxxxxx]
> Sent: Friday, September 24, 2010 4:14 PM
> To: Savoy, Pavan
> Cc: Anca Emanuel; devel@xxxxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH 1/1] Staging: ti-st: remove st_get_plat_device
> 
> On Fri, Sep 24, 2010 at 02:13:22PM -0700, Greg KH wrote:
> > On Sat, Sep 25, 2010 at 02:34:31AM +0530, Savoy, Pavan wrote:
> > >
> > > Greg,
> > >
> > > > -----Original Message-----
> > > > From: Greg KH [mailto:gregkh@xxxxxxx]
> > > > Sent: Friday, September 24, 2010 3:38 PM
> > > > To: Anca Emanuel
> > > > Cc: Savoy, Pavan; devel@xxxxxxxxxxxxxxxxxxxxxx
> > > > Subject: Re: [PATCH 1/1] Staging: ti-st: remove st_get_plat_device
> > > >
> > > > On Fri, Sep 24, 2010 at 11:21:38PM +0300, Anca Emanuel wrote:
> > > > > Building 2.6.36-rc5-git5
> > > > >
> > > > >  Building modules, stage 2.
> > > > >   MODPOST 3058 modules
> > > > > ERROR: "st_get_plat_device" [drivers/staging/ti-st/st_drv.ko]
> undefined!
> > > > > WARNING: modpost: Found 59 section mismatch(es).
> > > > > To see full details build your kernel with:
> > > > > 'make CONFIG_DEBUG_SECTION_MISMATCH=y'
> > > > > make[2]: *** [__modpost] Error 1
> > > > > make[1]: *** [modules] Error 2
> > > > > make[1]: Leaving directory `/home/username/linux-2.6'
> > > > > make: *** [debian/stamp/build/kernel] Error 2
> > > > >
> > > > >
> > > > > after:
> > > > > username@ubuntu:~/linux-2.6$ git pull
> > > > > http://www.kernel.org/pub/scm/linux/kernel/git/gregkh/staging-2.6.git
> > > > > master
> > > > >
> > > > > that error is gone.
> > > >
> > > > Great, that's why I sent the patch to Linus.
> > > >
> > > > Pavan, is this somehow incorrect?
> > >
> > > Nope. The patch is fine. Let is go into .36, all the better for me.
> > > Hopefully the merge issues will be resolved soon on linux-next too.
> >
> > Ah, ok, it's in Linus's tree now.
> >
> > I'll probably be rebasing the staging-next tree soon, depending on if
> > the merge issues are "tough" or not.
> 
> Actually, no, I really don't want to rebase as people are starting to
> pull from it directly.  I'll fix up the merge issues myself, it
> shouldn't be too bad...

Yep, OK thanks.
I guess it would just involve reverting specific GIT commits (the ones I mentioned in my previous mail, I'm not too good with quilt) in any case - the sources need to be rolled back to be patch "staging: ti-st: mv headers to ti_wilink_st" which should be the top-most patch on the drivers/staging/ti-st folder.

I just wanted to bring to notice that the existing tree (linux-next) has some issues, that's all.


> It will give me something to do on my next 10 hour plane ride, which
> leaves in a few hours...
It must be your idea of having fun on flights? :)

Thanks again,
Pavan.

> thanks,
> 
> greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux