Re: [PATCH 10/10] rtl8192e: Convert macros to inline functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/24/2010 12:40 PM, Mike McCormack wrote:
> --- a/drivers/staging/rtl8192e/dot11d.h
> +++ b/drivers/staging/rtl8192e/dot11d.h
> @@ -41,9 +41,11 @@ typedef struct _RT_DOT11D_INFO {
>  	DOT11D_STATE State;
>  } RT_DOT11D_INFO, *PRT_DOT11D_INFO;
>  
> -#define eqMacAddr(a, b) (((a)[0] == (b)[0] && (a)[1] == (b)[1] && (a)[2] == \
> -			(b)[2] && (a)[3] == (b)[3] && (a)[4] == (b)[4] && \
> -			(a)[5] == (b)[5]) ? 1 : 0)
> +static inline bool eqMacAddr(u8 *a, u8 *b)
> +{
> +	return a[0] == b[0] && a[1] == b[1] && a[2] == b[2] &&
> +	       a[3] == b[3] && a[4] == b[4] && a[5] == b[5];

Nice cleanup. However, this is a slower version of compare_ether_addr()...

-- 
js
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux