Re: [PATCH -next] staging/keucr: update TODO list and ask question about it

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 14, 2010 at 03:41:48PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> 
> Update keucr TODO with additional work items.
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> Cc: Al Cho <acho@xxxxxxxxxx>
> ---
>  drivers/staging/keucr/TODO |    3 +++
>  1 file changed, 3 insertions(+)
> 
> and I don't understand this TODO comment:
> "	- determine if the driver should not be using a duplicate
> 	  version of the usb-storage scsi interface code, but should
> 	  be merged into the drivers/usb/storage/ directory and
> 	  infrastructure instead."
> 
> Of course the driver should not use a duplicate of the usb-storage
> SCSI interface code.  Did someone seriously think that it should?

Well, it's not the whole copy, and we are still trying to unwind the
hooks here.  It might be that this is just another scsi driver, one that
happens to also be a USB device, as I don't think this device follows
the usb-storage spec at all.

So it's still an unanswered question.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux