On Thu, Sep 09, 2010 at 02:53:03PM +0000, Haiyang Zhang wrote: > > From: Greg KH [mailto:gregkh@xxxxxxx] > > Sent: Wednesday, September 08, 2010 6:44 PM > > > Convert vmbus driver interface function pointer table to constant > > > The vmbus interface functions are assigned to a constant - vmbus_ops. > > > > You also remove a function pointer in this patch, why? Please break up > > the patch into logical parts, one patch, one thing. > > > > This looks like it should be 2 patches, right? > > Because the vmbus interface function pointer table is converted to a > constant variable -- vmbus_ops, the function GetChannelInterface(), > VmbusGetChannelInterface() and pointer GetChannelInterface are no longer > in use. The deprecated function's work is done by the initialization of > the newly added constant variable vmbus_ops. > > I created the new constant variable vmbus_ops and removed the deprecated > function pointer GetChannelInterface in one patch. Great, next time say that in the patch please :) I'll go edit the wording and apply this... thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
