On Mon, Sep 13, 2010 at 02:58:18PM -0400, Jason wrote:
> I'm currently working through the checkpatch issues for
> staging/brcm80211/*, so far, I've done:
>
> ERROR: "foo * bar" should be "foo *bar"
> ERROR: open brace '{' following function dec...
> ERROR: return is not a function, paren...
> ERROR: do not use assignment in if condition
> ERROR: trailing statements should be on next line
> ERROR: that open brace { ... prev line
> ERROR: while should follow close brace '}'
> ERROR: do not initialise globals to 0 or NULL
> ERROR: do not initialise statics to 0 or NULL
> ERROR: Macros w/ complex values ... parenthesis
> ERROR: Macros w/ mult. statements ... do - while loop
>
> The only remaining errors are whitespace, then I'll move on to warnings.
> Since this is my first large (arguably trivial ;-) ) patchset, do you
> want them one by one as I finish them, or the whole thing in one shot?
One thing per commit please.
> btw, each "ERROR: ..." line above is one commit.
Great, so you should be all set. Send them on, I'll queue them up :)
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
