On Tue, Aug 3, 2010 at 10:31 PM, Joe Perches <joe@xxxxxxxxxxx> wrote:
> This change is broken.
> TYPE_PKT_IPX is one of 2 #defines based on BE/LE use.
>
> And perhaps this is more readable and correct as:
>
> if ((*pwType == cpu_to_le16(ETH_P_IPX)) ||
> (*pwType == cpu_to_le16(0xF380))) {
Thanks, it is definitely easier to read.
> Linux source generally has the logical test as end of line
>
> if (((Protocol_Version == 1) || (Protocol_Version == 2)) &&
> (Packet_Type == 3)) {
>
>
This is the second time you point that to me, I wish checkpatch.pl can
report that.
I will resend ASAP.
-- Andres
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
