On 07/30/2010 04:07 AM, Kulikov Vasiliy wrote:
request_irq() may fail, if so propagate error code.
Signed-off-by: Kulikov Vasiliy<segooon@xxxxxxxxx>
You can add:
Acked-by: David Daney <ddaney@xxxxxxxxxxxxxxxxxx>
---
drivers/staging/octeon/ethernet-spi.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/staging/octeon/ethernet-spi.c b/drivers/staging/octeon/ethernet-spi.c
index b58b897..9708254 100644
--- a/drivers/staging/octeon/ethernet-spi.c
+++ b/drivers/staging/octeon/ethernet-spi.c
@@ -294,6 +294,8 @@ int cvm_oct_spi_init(struct net_device *dev)
if (number_spi_ports == 0) {
r = request_irq(OCTEON_IRQ_RML, cvm_oct_spi_rml_interrupt,
IRQF_SHARED, "SPI",&number_spi_ports);
+ if (r)
+ return r;
}
number_spi_ports++;
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
