On Monday, July 26, 2010 3:35 PM, Greg KH wrote: > On Fri, Jul 23, 2010 at 01:03:34PM -0700, H Hartley Sweeten wrote: >> The symbols dt3155_dev_open, unique_tag, and allocatorAddr are only used in >> the file dt3155_drv.c and should be static. Also, as pointed out by Joe Perches, >> static variables do not need initialization so remove them. While here, also >> move the definition for allocatorAddr so that all the variables are declared at >> one place in the code. > > This doesn't apply after applying your previous patch to this file :( Oops.. I'll fix it up and repost. Regards, Hartley _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel