On Fri, Jul 23, 2010 at 12:36:44PM +0200, Jiri Slaby wrote: > On 07/23/2010 11:17 AM, Michael Jensen wrote: > > On Fri, Jul 23, 2010 at 6:53 PM, Jiri Slaby <jirislaby@xxxxxxxxx> wrote: > >> > > <snip> > >> Hmm, does this compile? > >> > > I did build the comedi directory (as per Greg's "Write and submit your > > first kernel patch" video), and didn't get any errors (once I'd done > > the configuration)... > > > > Did I miss something? > > Then the macro is probably unused (or unused in your configuration). > Either way, the macro seems to be intended for use in the top-level > scope, so do { } while (0) cannot be used there. I think we might have now removed all users of that macro, so it should just be deleted. Michael, can you do that instead of the do/while stuff here, as that is not a valid change. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel