Re: [PATCH 3/3] Correct: fix staging/spectra: don't use locked_ioctl

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 22, 2010 at 1:58 PM, Greg KH <greg@xxxxxxxxx> wrote:
>> +     lock_kernel();
>
> No, we are trying to get rid of the lock_kernel() calls, care to just
> make this a local lock instead?
>

Since I'm not the driver author I thought that the idea of moving the
BKL from block ioctl to the driver code would be a first step to get
rid of the lock_kernel() call.

This patch at least could make the driver compile again and someone
who better understands the driver code could make a finner (local)
lock.

But I will figure out what needs to be protect and send a new patch
that uses some sincronization primitive to make a local lock.

Thanks a lot.

-----------------------------------------
Javier Martínez Canillas
+595 981 88 66 58
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux