On Tue, Jul 06, 2010 at 07:29:47PM +0200, Charles Clément wrote:
> On Tue, Jul 06, 2010 at 08:18:27AM -0700, Greg Kroah-Hartman wrote:
> > On Tue, Jul 06, 2010 at 04:45:41PM +0200, Charles Clément wrote:
> > >
> > > Signed-off-by: Charles Clément <caratorn@xxxxxxxxx>
> > > ---
> > > drivers/staging/vt6655/80211mgr.c | 8 +-
> > > drivers/staging/vt6655/IEEE11h.c | 10 +-
> > > drivers/staging/vt6655/aes_ccmp.c | 4 +-
> > > drivers/staging/vt6655/baseband.c | 22 ++--
> > > drivers/staging/vt6655/bssdb.c | 98 ++++++++--------
> > > drivers/staging/vt6655/card.c | 146 ++++++++++++------------
> > > drivers/staging/vt6655/channel.c | 170 +++++++++++++-------------
> > > drivers/staging/vt6655/datarate.c | 8 +-
> > > drivers/staging/vt6655/device.h | 2 +-
> > > drivers/staging/vt6655/device_cfg.h | 4 -
> > > drivers/staging/vt6655/device_main.c | 126 ++++++++++----------
> > > drivers/staging/vt6655/dpc.c | 70 ++++++------
> > > drivers/staging/vt6655/hostap.c | 24 ++--
> > > drivers/staging/vt6655/ioctl.c | 56 +++++-----
> > > drivers/staging/vt6655/iwctl.c | 60 +++++-----
> > > drivers/staging/vt6655/key.c | 90 +++++++-------
> > > drivers/staging/vt6655/mac.c | 50 ++++----
> > > drivers/staging/vt6655/power.c | 14 +-
> > > drivers/staging/vt6655/rf.c | 74 ++++++------
> > > drivers/staging/vt6655/rxtx.c | 88 +++++++-------
> > > drivers/staging/vt6655/srom.c | 12 +-
> > > drivers/staging/vt6655/tether.c | 4 +-
> > > drivers/staging/vt6655/ttype.h | 3 -
> > > drivers/staging/vt6655/vntwifi.c | 32 +++---
> > > drivers/staging/vt6655/wcmd.c | 68 +++++------
> > > drivers/staging/vt6655/wctl.c | 16 ++--
> > > drivers/staging/vt6655/wmgr.c | 216 +++++++++++++++++-----------------
> > > drivers/staging/vt6655/wpa.c | 8 +-
> > > drivers/staging/vt6655/wpa2.c | 16 ++--
> > > drivers/staging/vt6655/wpactl.c | 24 ++--
> > > drivers/staging/vt6655/wroute.c | 10 +-
> > > 31 files changed, 761 insertions(+), 772 deletions(-)
> > >
> > > diff --git a/drivers/staging/vt6655/80211mgr.c b/drivers/staging/vt6655/80211mgr.c
> > > index 9156a0b..3d5daa5 100644
> > > --- a/drivers/staging/vt6655/80211mgr.c
> > > +++ b/drivers/staging/vt6655/80211mgr.c
> > > @@ -179,7 +179,7 @@ vMgrDecodeBeacon(
> > > break;
> > > case WLAN_EID_RSN_WPA:
> > > if (pFrame->pRSNWPA == NULL) {
> > > - if (WPAb_Is_RSN((PWLAN_IE_RSN_EXT)pItem) == TRUE)
> > > + if (WPAb_Is_RSN((PWLAN_IE_RSN_EXT)pItem) == 1)
> >
> > That's great, but if you convert these to use the 'bool' type, why not
> > then use the 'true' and 'false' enumerated types that are in the kernel
> > already?
>
> I wasn't trying to use the bool type but rather get rid of the BOOL that
> was already defined. I haven't seen the kernel bool type a lot but can
> redo the patch if it is better using it.
Yeah, it would be best to do that, for all 3 of these.
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
