Re: [PATCH] Staging: vt6655: simplify broadcast and multicast ethernet address test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2010-06-29 at 23:32 -0700, Charles Clément wrote:
> A broadcast address is also a multicast address so simplify test cases where
> possible.

So the tests could be simplified to is_multicast_ether_addr.

> As suggested by Joe Perches.

Well, kind of ;)

> Signed-off-by: Charles Clément <caratorn@xxxxxxxxx>

> -    if (!is_multicast_ether_addr(pbyFrame) && !is_broadcast_ether_addr(pbyFrame)) {
> +    if (!is_broadcast_ether_addr(pbyFrame)) {

nack.

cheers, Joe

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux