On 24.6.2010, at 12.16, Alan Cox wrote:
>> +size_t memrar_allocator_largest_free_area(struct memrar_allocator *allocator)
>> +{
>> + if (allocator == NULL)
>> + return 0;
>> + return allocator->largest_free_area;
>> +}
>
> static ?
The entire point of these two patches was to hide the memrar_allocator structure by moving it to memrar_allocator.c, forward declaring it in memrar_allocator.h and then providing accessor functions memrar_allocator_largest_free_area and memrar_allocator_capacity (this was the #2 issue for memrar_allocator.[ch] in the TODO file). By defining memrar_allocator_largest_free_area function as static (this is what you mean, right?) would make no sense.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
