On Wed, Jun 23, 2010 at 11:06:30AM -0700, Randy Dunlap wrote: > Greg KH wrote: > > On Mon, Jun 21, 2010 at 09:00:49AM -0700, Randy Dunlap wrote: > >> On Mon, 21 Jun 2010 17:00:56 +1000 Stephen Rothwell wrote: > >> > >>> Hi all, > >>> > >>> Changes since 20100618: > >> > >> When CONFIG_USB is not enabled: > >> > >> ERROR: "usb_kill_urb" [drivers/staging/easycap/easycap.ko] undefined! > >> ERROR: "usb_deregister_dev" [drivers/staging/easycap/easycap.ko] undefined! > >> ERROR: "video_register_device" [drivers/staging/easycap/easycap.ko] undefined! > >> ERROR: "usb_deregister" [drivers/staging/easycap/easycap.ko] undefined! > >> ERROR: "video_unregister_device" [drivers/staging/easycap/easycap.ko] undefined! > >> ERROR: "usb_set_interface" [drivers/staging/easycap/easycap.ko] undefined! > >> ERROR: "usb_register_dev" [drivers/staging/easycap/easycap.ko] undefined! > >> ERROR: "usb_control_msg" [drivers/staging/easycap/easycap.ko] undefined! > >> ERROR: "usb_submit_urb" [drivers/staging/easycap/easycap.ko] undefined! > >> ERROR: "usb_get_dev" [drivers/staging/easycap/easycap.ko] undefined! > >> ERROR: "usb_find_interface" [drivers/staging/easycap/easycap.ko] undefined! > >> ERROR: "usb_register_driver" [drivers/staging/easycap/easycap.ko] undefined! > >> ERROR: "usb_free_urb" [drivers/staging/easycap/easycap.ko] undefined! > >> ERROR: "usb_alloc_urb" [drivers/staging/easycap/easycap.ko] undefined! > >> > >> > >> Adding "depends on USB" to EASYCAP is a good start. > >> After that and enabling CONFIG_USB, build of easycap gets: > >> > >> ERROR: "video_register_device" [drivers/staging/easycap/easycap.ko] undefined! > >> ERROR: "video_unregister_device" [drivers/staging/easycap/easycap.ko] undefined! > >> > >> because there is no media/video support enabled. Also no SOUND enabled, > >> so I expect there to be build errors associated with sound also, meaning that > >> the Kconfig file should probably modified with something like > >> > >> config EASYCAP > >> + depends on USB && VIDEO_DEV && SND > >> > >> > >> This is something that the driver author should know the answer to and submit a > >> patch for. > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > > > > You are right, care to make up a patch for this? > > No thanks, please see my last statement above. > IOW, I want the driver developer (not you) to act responsibly on this. Ok, I'm working with them right now on this. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
